napari / napari-animation

A napari plugin for making animations
https://napari.github.io/napari-animation/
Other
77 stars 27 forks source link

Fixed deleteButton and easings support #101

Closed Fifourche closed 3 years ago

Fifourche commented 3 years ago

There was an issue with easings, that are currently not taken into account ; a small piece of code was missing. Also, the delete button is enabled by default even when animation contains no keyframe upon initialization.

This PR fixes both !

codecov[bot] commented 3 years ago

Codecov Report

Merging #101 (d73db97) into main (dc135bf) will increase coverage by 0.13%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   89.95%   90.08%   +0.13%     
==========================================
  Files          20       20              
  Lines         826      827       +1     
==========================================
+ Hits          743      745       +2     
+ Misses         83       82       -1     
Impacted Files Coverage Δ
napari_animation/_qt/keyframelistcontrol_widget.py 100.00% <100.00%> (ø)
napari_animation/frame_sequence.py 100.00% <100.00%> (ø)
napari_animation/easing.py 70.37% <0.00%> (+0.92%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc135bf...d73db97. Read the comment docs.