napari / napari-animation

A napari plugin for making animations
https://napari.github.io/napari-animation/
Other
76 stars 27 forks source link

jumpy transitions between keyframes #113

Closed alisterburt closed 1 year ago

alisterburt commented 2 years ago

looks like there has been some sort of regression which makes the transitions between keyframes jump around

I'm not sure under what circumstances it occurs exactly yet, it seems like playing with the preview slider before capturing keyframes is part of the problem

https://user-images.githubusercontent.com/7307488/142078462-9089fa3e-c61d-43ad-bb99-59bcd389c6b4.mp4

@maweigert you were using the plugin recently, is this something you ran into?

maweigert commented 2 years ago

@maweigert you were using the plugin recently, is this something you ran into?

Hm, I didn't run into it, yet I can reproduce it...

alisterburt commented 2 years ago

thanks for taking a look! I'll keep digging 🙂

alisterburt commented 2 years ago

unsuccesful bug hunt, need to call it quits for tonight, mini report...

for i in range(31):
    print(animation._frames[i].camera['zoom'])

1.890401643454949
1.8904016434549489
1.8904016434549489
1.8904016434549489
1.8904016434549487
1.8904016434549487
1.8904016434549487
1.8904016434549487
1.8904016434549487
1.8904016434549487
1.8904016434549487
1.8904016434549487
1.8904016434549484
1.8904016434549484
1.8904016434549484
1.8904016434549484
1.8904016434549484
1.8904016434549484
1.8904016434549484
1.8904016434549487
1.8904016434549487
1.8904016434549487
1.8904016434549487
1.8904016434549487
1.8904016434549487
1.8904016434549487
1.8904016434549487
1.8904016434549489
1.8904016434549489
1.8904016434549489
1.890401643454949

I recently installed this and other things into a fresh environment on another machine and didn't have any problems. Bug is definitely not super reproducible so far...

alisterburt commented 1 year ago

fixed upstream in vispy!