napari / napari-animation

A napari plugin for making animations
https://napari.github.io/napari-animation/
Other
76 stars 27 forks source link

refactor viewer state interpolation machinery #119

Closed alisterburt closed 1 year ago

alisterburt commented 2 years ago

refactor and separation of everything to do with the interpolation of ViewerState

Added a fix for the error generating keys seen in #118 and allow us to move forwards there

JoOkuma commented 2 years ago

I made a PR alisterburt/napari-animation/pull/1 with some changes.

codecov[bot] commented 1 year ago

Codecov Report

Merging #119 (438f5e1) into main (54aa0e5) will increase coverage by 0.05%. The diff coverage is 97.41%.

:exclamation: Current head 438f5e1 differs from pull request most recent head c47b242. Consider uploading reports for the commit c47b242 to get more accurate results

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   84.94%   85.00%   +0.05%     
==========================================
  Files          21       24       +3     
  Lines         930      920      -10     
==========================================
- Hits          790      782       -8     
+ Misses        140      138       -2     
Impacted Files Coverage Δ
napari_animation/_qt/frame_widget.py 81.57% <0.00%> (ø)
napari_animation/viewer_state.py 93.33% <93.33%> (ø)
...pari_animation/viewer_state_interpolation/utils.py 97.14% <97.14%> (ø)
napari_animation/_qt/animation_widget.py 84.37% <100.00%> (ø)
napari_animation/_tests/conftest.py 96.87% <100.00%> (-0.10%) :arrow_down:
napari_animation/_tests/test_frame_sequence.py 100.00% <100.00%> (ø)
napari_animation/_tests/test_interpolation.py 100.00% <100.00%> (ø)
napari_animation/_tests/test_utils.py 100.00% <100.00%> (ø)
napari_animation/animation.py 86.86% <100.00%> (ø)
napari_animation/frame_sequence.py 98.61% <100.00%> (-0.23%) :arrow_down:
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.