napari / napari-animation

A napari plugin for making animations
https://napari.github.io/napari-animation/
Other
74 stars 27 forks source link

refactor file name filter logic in `SaveDialogWidget` #134

Closed alisterburt closed 1 year ago

alisterburt commented 1 year ago

just a minor tidyup

cc @katherine-hutchings - it took us a bit too long to figure out what was going on in the save dialog widget/where information was coming from, this should make things a little clearer for people in the same boat in the future

codecov[bot] commented 1 year ago

Codecov Report

Merging #134 (9efffb6) into main (81a2ba3) will increase coverage by 0.06%. The diff coverage is 38.46%.

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   85.23%   85.29%   +0.06%     
==========================================
  Files          24       24              
  Lines         921      925       +4     
==========================================
+ Hits          785      789       +4     
  Misses        136      136              
Impacted Files Coverage Δ
napari_animation/_qt/savedialog_widget.py 20.28% <38.46%> (+4.90%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.