napari / napari-animation

A napari plugin for making animations
https://napari.github.io/napari-animation/
Other
74 stars 27 forks source link

napari-animation excessive memory usage #143

Closed JoOkuma closed 10 months ago

JoOkuma commented 1 year ago

Hi, I had some problems running napari-animation with large datasets. It uses too much memory, sometimes even crashing due to running out-of-memory.

I think the problem is in here, where the _cache that keeps growing without limit.

JoOkuma commented 1 year ago

Defining a maximum cache size fixes the issue, should I open a PR?

alisterburt commented 1 year ago

ooft! Yes please, PR would be welcome, thanks @JoOkuma !

psobolewskiPhD commented 10 months ago

I think this can be closed by: https://github.com/napari/napari-animation/pull/150 ?

JoOkuma commented 10 months ago

Yes, thanks @psobolewskiPhD. Closed by #150