Closed JoOkuma closed 1 year ago
Merging #144 (28d2258) into main (d8bd609) will increase coverage by
0.14%
. The diff coverage is50.00%
.
@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 85.31% 85.46% +0.14%
==========================================
Files 24 26 +2
Lines 926 956 +30
==========================================
+ Hits 790 817 +27
- Misses 136 139 +3
Impacted Files | Coverage Δ | |
---|---|---|
napari_animation/frame_sequence.py | 94.80% <50.00%> (-3.81%) |
:arrow_down: |
napari_animation/__init__.py | 100.00% <0.00%> (ø) |
|
napari_animation/utils.py | 100.00% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
thanks for the PR @JoOkuma ! I don't love the implementation so will followup with an lru_cache appraoch over the break :)
closed by #150
Closes #143
This is a quick solution, I did not dive deep into frame sequence logic. It might be better to implement using python
lru_cache
.If that's the case I can update it in a few days when I have more time.