Closed bentaculum closed 7 months ago
Hey @bentaculum
Thanks for the nice bug report! I haven't had a chance to take a look yet, I want to help but to set expectations I just moved to a new continent and started a new job so am pretty low bandwidth right now. If you're capable of finding the bug/submitting a pull request I'm very happy to get a fix merged but not sure when I can take a look myself right now.
Many thanks!
Alister
Could you post full output of napari --info
?
I have a different issue with Labels animations, see:
https://github.com/napari/napari-animation/issues/180
so it's interesting that you say the visible Labels works for you.
Anyhow I have a fix PR (https://github.com/napari/napari-animation/pull/181) for labels (and other layer types) and with that branch I can replicate the issue. I'll try and take a look at the root cause of this issue too, because it involves the same lines of code (the storing of the viewer state)
There was an issue with https://github.com/napari/napari-animation/pull/181 that was spotted by a user on image.sc (https://forum.image.sc/t/issue-saving-animations-in-napari-animation/88868/8?u=psobolewskiphd). After fixing, I can no longer reproduce this issue, so I think #181 solves this! 🎉
Hi @psobolewskiPhD, thanks for looking into this. Here's my napari --info
in case still needed:
napari --info
napari: 0.4.18
Platform: macOS-12.7-arm64-arm-64bit
System: MacOS 12.7
Python: 3.10.12 | packaged by conda-forge | (main, Jun 23 2023, 22:41:52) [Clang 15.0.7 ]
Qt: 5.15.8
PyQt5: 5.15.9
NumPy: 1.23.5
SciPy: 1.11.2
Dask: 2023.9.2
VisPy: 0.12.2
magicgui: 0.7.3
superqt: 0.5.4
in-n-out: 0.1.8
app-model: 0.2.1
npe2: 0.7.2
OpenGL:
- GL version: 2.1 Metal - 76.3
- MAX_TEXTURE_SIZE: 16384
Screens:
- screen 1: resolution 1728x1117, scale 2.0
Settings path:
- /Users/gallusse/Library/Application Support/napari/trackastra_0d3c3869e2a7fdacd6ade9a31c9f813beb43b53b/settings.yaml
Plugins:
- napari: 0.4.18 (77 contributions)
- napari-animation: 0.0.7 (2 contributions)
- napari-console: 0.0.8 (0 contributions)
- napari-manual-transforms: 0.0.3 (2 contributions)
- napari-open-ctc: 0.1.dev2+geee37b4.d20231030 (2 contributions)
- napari-svg: 0.1.10 (2 contributions)
- trackastra: 0.1.0 (2 contributions)
Thanks a lot for developing this nice plugin :)
I just noticed the following: If there is a hidden
Labels
layer present in the viewer,Animation.animate
crashes while trying to update some layer thumbnail. This looks like a bug to me, it didn't occur to me that I'm not allowed to have some hidden layers floating around when creating an animation.Here is a minimal example. The first animation is written fine, after adding the
Labels
layer withvisible=False
I get the error below.Error message:
python: 3.10.12 napari: 0.4.18 napari-animation: 0.0.7