search

napari / napari-animation

A napari plugin for making animations
https://napari.github.io/napari-animation/
Other
74 stars 27 forks source link

Switch to PyPI Trusted Publishing, and remove twine #212

Closed GenevieveBuckley closed 1 month ago

GenevieveBuckley commented 1 month ago

Closes https://github.com/napari/napari-animation/issues/211

This PR switches to PyPI deployment with Trusted Publishing (see the announcement and how trusted publishing works). It removes twine, and also removes the need for PyPI API tokens being used as github secrets.

This PR is not sufficient on its own, someone else also needs to:

GenevieveBuckley commented 1 month ago

PR marked as draft, so it doesn't get merged before someone enables trusted publishing on PyPI

psobolewskiPhD commented 1 month ago

99% sure trusted published was enabled for this repo, but not sure how to check.

alisterburt commented 1 month ago

Just run it and see, no big deal if it fails!

jni commented 1 month ago

it's enabled.

jni commented 1 month ago

Just run it and see, no big deal if it fails!

loss aversion is powerful stuff. 😂

https://www.nytimes.com/interactive/2015/07/03/upshot/a-quick-puzzle-to-test-your-problem-solving.html

GenevieveBuckley commented 1 month ago

CI tests failing, a fix is in progress here: https://github.com/napari/napari-animation/pull/214

alisterburt commented 1 month ago

Just run it and see, no big deal if it fails!

loss aversion is powerful stuff. 😂

https://www.nytimes.com/interactive/2015/07/03/upshot/a-quick-puzzle-to-test-your-problem-solving.html

😆 thanks for this! Interesting read :)

GenevieveBuckley commented 1 month ago

PR https://github.com/napari/napari-animation/pull/218 should fix the ruff CI errors

jni commented 1 month ago

😆 thanks for this! Interesting read :)

@alisterburt did you pass the test? I am sad to admit that I was one of the 77% of chumps who confidently guessed powers of 2 after a bunch of positive tests. 😬

The crazy thing is that I consciously think about that test/article often, but still suffer from it. I'll spend so much time setting things up just-so, even when there is literally no cost to failure. But I deeply don't want the computer-says-no message! Stupid brain! 🧠 😂

jni commented 1 month ago

@GenevieveBuckley wanna merge in main? 🙏 Then this should be ready to go in! 🚀

GenevieveBuckley commented 1 month ago

Ready to merge when the CI checks are all green. Then we'll need someone to test a release candidate, to see if the PyPI trusted publishing works.