search

napari / napari-animation

A napari plugin for making animations
https://napari.github.io/napari-animation/
Other
79 stars 27 forks source link

Attempt to fix failing CI tests #221

Closed GenevieveBuckley closed 5 months ago

GenevieveBuckley commented 5 months ago

This PR:

  1. Drops python 3.8, and adds python 3.12 to the CI test matrix
  2. Pins macos-13, the latest Intel mac version, for the CI tests. PySide2 is unavailable for Apple Silicon mac, and pip install imageio[ffmpeg] also does not include the ffmpeg binary for Apple Silicon mac (but imageio can still work if you install ffmpeg separately)
  3. Skips PySide CI tests on Windows platforms, and on all platforms for python >3.10

napari is experiencing CI failures with PySide backends on Windows platforms for all versions of python, and on all platforms with python greater than 3.10. Also, PySide2 is not currently available for macos arm-64 machines.

Python 3.11 PySide problems:

Windows PySide problems:

Previously:

GenevieveBuckley commented 5 months ago

Turns out you can run the PySide tests on Windows (possibly the napari discussion was a bit confused by the fact PySide requires python<=3.10). Also turns out, it's relatively easy to fix the ffmpeg install problem on Apple Silicon mac as well.

Fixes here: https://github.com/napari/napari-animation/pull/222