napari / napari-animation

A napari plugin for making animations
https://napari.github.io/napari-animation/
Other
79 stars 27 forks source link

Fix order of connection. Version 2 #234

Closed Czaki closed 2 months ago

Czaki commented 2 months ago

This PR is resolving the problem described in #231 by enforcing that FrameSequence events are connected before Animation events

closes #231 closes #232 closes #233

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.24%. Comparing base (ba8ab53) to head (2e4e1f4). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #234 +/- ## ======================================= Coverage 86.24% 86.24% ======================================= Files 26 26 Lines 1076 1076 ======================================= Hits 928 928 Misses 148 148 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alisterburt commented 2 months ago

Awesome, thanks @Czaki !