napari / napari-animation

A napari plugin for making animations

https://napari.github.io/napari-animation/

Other

76 stars 27 forks source link

Fix key-binding to move across frames #41

Closed guiwitz closed 3 years ago

guiwitz commented 3 years ago

This is a tiny PR which fixes the key-bindings Alt-a and Alt-b. First, because of a bug (missing call to 'viewer' key from the state dictionary) the key-bindings were not functional. Second, once that was fixed I realized that the selection of the key-frame widget row was not updating when moving across key-frames, and this PR fixes that as well.

guiwitz commented 3 years ago

Thanks to you and @sofroniewn for turning my initial work into this plugin! It's much nicer to have an actual interface and the handling of interpolation calculation is super sleek now! I'll have a bit of time to work on this and have already implemented things like e.g. a slider to move across key-frames. However I don't want to do PRs without discussing first in what direction you want to go (except to fix bugs like here). Is there a place where to discuss plans for this plugin @sofroniewn ?

alisterburt commented 3 years ago

Not trying to speak for Nick but I guess the napari zulip chat is a good place! Otherwise in the issues here?

Can't wait to hear about your ideas - I was playing with a 'timeline' idea which sounds similar to your slider. Will be fun to discuss!

codecov[bot] commented 3 years ago

Codecov Report

Merging #41 (26c844f) into main (2ca2ee9) will decrease coverage by 0.18%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   55.35%   55.17%   -0.19%     
==========================================
  Files          15       15              
  Lines         607      609       +2     
==========================================
  Hits          336      336              
- Misses        271      273       +2

Impacted Files	Coverage Δ
napari_animation/_qt/animation_widget.py	`27.83% <0.00%> (-0.59%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ca2ee9...26c844f. Read the comment docs.

guiwitz commented 3 years ago

It looks like @alisterburt had already fixed part of the problem. I resolved the conflict now. It seem that when I did "git clone", I got the last version of the repository with a commit from @sofroniewn (this one https://github.com/napari/napari-animation/tree/1fa7b650e5ed3693a2d0a25b4b81f59ed802feae) and not the "real" last one with latest commits from @alisterburt. Is that something that happens?

alisterburt commented 3 years ago

@guiwitz it could be that those commits were made a while ago but only recently merged into master? I did have a similar thing recently on another repo though when using the github CLI tool to clone something - in any case thanks for sorting!