search

napari / napari-animation

A napari plugin for making animations
https://napari.github.io/napari-animation/
Other
79 stars 27 forks source link

change from itemClicked to itemSelectionChanged in KeyFramesListWidget #57

Closed alisterburt closed 3 years ago

alisterburt commented 3 years ago

fix for #50 may also solve #51

codecov[bot] commented 3 years ago

Codecov Report

Merging #57 (0a2e349) into main (3154da4) will not change coverage. The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   62.57%   62.57%           
=======================================
  Files          15       15           
  Lines         708      708           
=======================================
  Hits          443      443           
  Misses        265      265
Impacted Files Coverage Δ
napari_animation/_qt/keyframeslist_widget.py 28.23% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3154da4...0a2e349. Read the comment docs.

sofroniewn commented 3 years ago

I can confirm this fixes #50, i might not quite be understanding #51, I couldn't reproduce it. Regardless this change looks good. I will merge now