napari / napari-animation

A napari plugin for making animations
https://napari.github.io/napari-animation/
Other
79 stars 27 forks source link

CI failing on windows with openGL eorrs on vispy import #64

Closed alisterburt closed 3 years ago

alisterburt commented 3 years ago

https://github.com/napari/napari-animation/pull/61/checks?check_run_id=2465586503#step:9:132

This is the only thing stopping us from merging #61 which we want to merge before #49 which we want for the 0.0.1 release.

Given that the error seems unrelated to our tests I'm tempted to just merge but merging in spite of failed CI feels like a wrong move

@sofroniewn @tlambert03 any advice would be appreciated

tlambert03 commented 3 years ago

the windows opengl installation has been fixed upstream in the meantime... so I just restarted the job. let's see if it passes

tlambert03 commented 3 years ago

yep! https://github.com/napari/napari-animation/pull/61/checks?check_run_id=2469622790

alisterburt commented 3 years ago

the 🧙🏼‍♂️ strikes again! thanks!