search

napari / napari-animation

A napari plugin for making animations
https://napari.github.io/napari-animation/
Other
79 stars 27 forks source link

Fix bug in setting the animation writer options #75

Closed guiwitz closed 3 years ago

guiwitz commented 3 years ago

Two types of imageio writers are used depending on the chosen file type. A series of file types (mov, avi etc) gives access to more options such as e.g. quality. The problem is that the dot sign in the list of extensions used to check the desired format is missing. As the suffix parameter of a pathlib.Path object returns extensions with a dot, the more complex writer is just ignored. This is a silent bug as no error is produced and passed options like quality are just ignored. This PR fixes this problem.

codecov[bot] commented 3 years ago

Codecov Report

Merging #75 (a2d9465) into main (14ad2c1) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   67.06%   67.06%           
=======================================
  Files          17       17           
  Lines         841      841           
=======================================
  Hits          564      564           
  Misses        277      277
Impacted Files Coverage Δ
napari_animation/animation.py 79.54% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14ad2c1...a2d9465. Read the comment docs.