napari / napari-animation

A napari plugin for making animations

https://napari.github.io/napari-animation/

Other

76 stars 27 forks source link

Stylesheet fix #83

Closed alisterburt closed 3 years ago

alisterburt commented 3 years ago

fix broken plugin import due to deprecation of qt_viewer.raw_stylesheet in napari 0.4.8 napari/napari#2643 - fixed by mirroring the napari console implementation https://github.com/napari/napari-console/blob/fd3a291331e052e591042850b56fd1db5815f784/napari_console/qt_console.py#L151-L171

alisterburt commented 3 years ago

removing extra commit!!

sofroniewn commented 3 years ago

This PR also has the skeleton docs, can you remove them, thanks!!

codecov[bot] commented 3 years ago

Codecov Report

Merging #83 (b946428) into main (a2be8d9) will decrease coverage by 0.04%. The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   67.06%   67.02%   -0.05%     
==========================================
  Files          17       17              
  Lines         841      843       +2     
==========================================
+ Hits          564      565       +1     
- Misses        277      278       +1

Impacted Files	Coverage Δ
napari_animation/_qt/animation_widget.py	`26.44% <0.00%> (-0.23%)`	:arrow_down:
napari_animation/_hookimpls.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2be8d9...b946428. Read the comment docs.

sofroniewn commented 3 years ago

Do we need to bump a minimum napari version? or was this in 0.4.5 already? We might need to bump for other reasons, but if not lets leave it

sofroniewn commented 3 years ago

Looks like it should have been in 0.4.5 https://github.com/napari/napari/pull/2241

alisterburt commented 3 years ago

tested locally and working with 0.4.5! Think we're good to go

tlambert03 commented 3 years ago

hang on before merging this... the console repo is not a good one to mimic here... since it needs to do specific things with theming because of upstream QtConsole weirdness. in almost all cases, the best approach (if possible) is not to set the theme and stylesheet at all, but let it be naturally inherited from the parent. lemme see if I can try

alisterburt commented 3 years ago

good to know, thanks - I think the original theming was done before provide_dock_widget so indeed might be unnecessary now!

sofroniewn commented 3 years ago

Ok, nice looks like this was all we needed, and we've also fixed the stretch. Will merge now. Thanks all!!

tlambert03 commented 3 years ago

nooo :joy: ... ok will submit a new PR :)

sofroniewn commented 3 years ago

loooooolz

sofroniewn commented 3 years ago

hang on before merging this...

ahhhhhhhh