Fifourche commented 3 years ago

To solve #81, I took the Slerp class from scipy and allowed extrapolation. I put the code in "utils" to prevent "interpolation.py" to be even less readable, but I can move it !

codecov[bot] commented 3 years ago

Codecov Report

Merging #85 (cf6dddf) into main (c0e939d) will decrease coverage by 1.15%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   68.11%   66.95%   -1.16%     
==========================================
  Files          17       17              
  Lines         828      802      -26     
==========================================
- Hits          564      537      -27     
- Misses        264      265       +1

Impacted Files	Coverage Δ
napari_animation/utils.py	`95.45% <ø> (-1.99%)`	:arrow_down:
napari_animation/_tests/test_utils.py	`100.00% <100.00%> (ø)`
napari_animation/interpolation.py	`100.00% <100.00%> (ø)`
napari_animation/_qt/frame_widget.py	`34.09% <0.00%> (-0.80%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0e939d...cf6dddf. Read the comment docs.

alisterburt commented 3 years ago

PR proposed at Fifourche/napari-animation#2

Fifourche commented 3 years ago

Cool ! :) I had switch to scipy Rotation for conversion between Euler angles and rotation but forgot to use it too for the back conversion ; @alisterburt 's PR then also get rid of quaternion2euler which was also 'vendored' from napari anyways ! Thanks a lot 🎉

alisterburt commented 3 years ago

Awesome - great work @Fifourche, was fun to work on this together!!

napari / napari-animation

Made a modified copy of scipy's slerp to handle spherical extrapolation. #85

Codecov Report