search

napari / napari-animation

A napari plugin for making animations
https://napari.github.io/napari-animation/
Other
76 stars 27 forks source link

remove unnecessary duplication of state interpolation #96

Closed alisterburt closed 3 years ago

alisterburt commented 3 years ago

state interpolation code was duplicated - removed and fixed test to account for the change

took the opportunity to move some testing utilities into util, they could also be moved to utils.testing if people prefer

A PR will follow based on this fixing the messy asdict stuff

@Fifourche

codecov[bot] commented 3 years ago

Codecov Report

Merging #96 (685c6b6) into main (f384675) will decrease coverage by 0.16%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   90.11%   89.95%   -0.17%     
==========================================
  Files          20       20              
  Lines         840      826      -14     
==========================================
- Hits          757      743      -14     
  Misses         83       83
Impacted Files Coverage Δ
napari_animation/frame_sequence.py 100.00% <ø> (ø)
napari_animation/interpolation.py 100.00% <ø> (+2.04%) :arrow_up:
napari_animation/_tests/test_interpolation.py 100.00% <100.00%> (ø)
napari_animation/utils.py 98.18% <100.00%> (+0.74%) :arrow_up:
napari_animation/_tests/conftest.py 96.96% <0.00%> (-3.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f384675...685c6b6. Read the comment docs.

alisterburt commented 3 years ago

good point! do you want to make an issue for this?