search

narcisoguillen / kafka-node-avro

ISC License
26 stars 13 forks source link

Schema Registry with Basic Authentication #9

Closed brunodomenici closed 5 years ago

brunodomenici commented 5 years ago

Hello,

Nice job with this project!

Our Schema Registry use Basic Authentication, can we include parameters for Basic Auth in request http-authentication?

https://github.com/narcisoguillen/kafka-node-avro/blob/ff25715ae576a3a8119da0cdaa77d36c1a12f973/lib/registry.js#L6-L13

I can contribute if you want.

Thank you.

brunodomenici commented 5 years ago

Well, I just saw that we can set it in http://username:password@url. My problem it was that I wasn't encoding my password. Thanks!

narcisoguillen commented 4 years ago

Hey thanks for using kafka-node-avro !! ... If you want to contribute you are welcome to 🍺 , the idea is to make this library better.