search

nasaharvest / presto

Lightweight, Pre-trained Transformers for Remote Sensing Timeseries
https://arxiv.org/abs/2304.14065
MIT License
151 stars 26 forks source link

Allow custom model path #22

Closed kvantricht closed 8 months ago

kvantricht commented 8 months ago

Simplest solution for my issue (raised in https://github.com/nasaharvest/presto/issues/21) right now is something like this. Let me know what you think.

gabrieltseng commented 8 months ago

Aside from the single comment, this looks good to me. Thank you @kvantricht !

gabrieltseng commented 8 months ago

@kvantricht isort is failing. We run the following linting / formatting checks against the code: 

isort . 
black .
flake8 .
kvantricht commented 8 months ago

@kvantricht isort is failing. We run the following linting / formatting checks against the code:

isort . 
black .
flake8 .

okay new attempt ;-)

kvantricht commented 8 months ago

Argh this is a struggle, seems that my own linter screwed up some other formatting ...

gabrieltseng commented 8 months ago

Argh this is a struggle, seems that my own linter screwed up some other formatting ...

I am happy to make these changes, since I have everything set up locally

kvantricht commented 8 months ago

Argh this is a struggle, seems that my own linter screwed up some other formatting ...

I am happy to make these changes, since I have everything set up locally

If I run black ., then he's indeed going to revert that one formatting change but also remove some blank lines. So I'm not sure why it's behaving differently here. Please go ahead if it's an easy fix on your side.