Custom MapCardEntityMarker - Githubissues

nathan-gs / ha-map-card

A Map Card for Home Assistant

https://community.home-assistant.io/t/map-card-a-slightly-improved-map-card/693088

MIT License

15 stars 4 forks source link

Custom MapCardEntityMarker #37

Closed thybag closed 1 month ago

thybag commented 1 month ago

Further to discussion on https://github.com/nathan-gs/ha-map-card/issues/1, I've had a quick play with adding a MapCardEntityMarker so that pictures show as expected on the maps.

Key changes:

Added MapCardEntityMarker component and registered it.
Tap event implemented via hass-action which should make it easier to support configurable events on click https://developers.home-assistant.io/blog/2023/07/07/action-event-custom-cards/
Initially kept the attributes on MapCardEntityMarker the same as provided by ha-entity-marker

From testing locally

Entities render correctly, even when ha-entity-marker is missing.
Tap event works as expected.

nathan-gs commented 1 month ago

Code itself looks good, will test and merge! Thank you @thybag!