Closed thybag closed 1 month ago
Hi @nathan-gs, think this should hopefully be good to review. Have tested a variety of combos and everything seems happy/working.
What would your thought me on me reorganizing the codebase a bit in a future PR (Breaking it down in to separate files), as with the growing complexity its getting a bit unwieldly all in one. Not 100% if HACS supports distributing multiple files for a single card or whether a simple build step would be required just to inline them all into a dist version.
@thybag thank you! I will review when at a pc.
I was thinking the same, multiple files with a build step to combine. Ideally this way we could also add some unit tests.
Now my experience in the Javascript ecosystem is limited, so will need to do some research.
Please note, if you are happy with the structure changes in https://github.com/nathan-gs/ha-map-card/pull/49, you may be better skipping this PR and merging that instead just to avoid some of the merge conflict fun.
Closing this to continue in #49
See https://github.com/nathan-gs/ha-map-card/issues/45
This PR expands the history exploration features for the MapCard, but allowing history be controlled via external entities. This can be used either as an alternative to the
history_date_selection
system, or in tandem with it if setup at entity level.For example if you setup
input_number.test_number_value
as a helper managed by acustom:numberbox-card
card.You could also setup an end similarly
Custom units can be provided via the following setup
A date entity an also be used rather than a number one if prefered. Suffix only gets added when the state linked is numeric.
All of this can additionally be set at entity level
Overview of changes
history_date_selection:true
, if you have a specific entity you want to show with a separate range.debug
option to toggle debug messages on/off as there are quite a few of them now.