search

navit-gps / navit

The open source (GPL v2) turn-by-turn navigation software for many OS
http://www.navit-project.org
Other
551 stars 174 forks source link

Missing bussines_service.xpm #428

Open aerostitch opened 6 years ago

aerostitch commented 6 years ago

Based on @lains comment in #421: I do see it:

$ grep -Ri bussines *
navit/map/garmin/garmintypes.txt:1, 0x1011 = poi_bussines_service, Business Service
navit/map/garmin/garmintypes.txt:1, 0x1501 = poi_bussines_service, Bussines Service
navit/navit_shipped.xml:                                        <icon src="bussines_service.xpm"/>
navit/navit_shipped.xml:                                        <icon src="bussines_service.xpm"/>
navit/navit_shipped.xml:          <icon src="bussines_service.png" />
$

But it seems no icon is corresponding to it

$ find . -iname '*bussines*'
$ find . -iname '*business*'
$

That's probably an issue. I guess we could fix the typo (bussines vs business) but if no icon exists with or without the typo, what's the process? Is it just something we are waiting a contribution for?

jkoan commented 6 years ago

Hi @aerostitch Missing icons are no deal breaker because they will noch crash the build. The build process itself is somewhat robust that it will simply convert all svgs and xpms inside the icons folder. There is no correlation between navit.xml and the real icons.

If a icon does not exist while navit is running it will throw a message (saying that icon xyz is missing) and continues its work.

So I think this should not be a problem.

aerostitch commented 6 years ago

Pinging @youte62 as I know he's been contributing to a lot of icons. If you have time to look at a potential business_service icon (the typo fix is in #430) that would be awesome, thanks! :)