navit-gps / navit

The open source (GPL v2) turn-by-turn navigation software for many OS
http://www.navit-project.org
Other
557 stars 175 forks source link

CMake has multiple complains in the build log #967

Open aerostitch opened 4 years ago

aerostitch commented 4 years ago

Just putting here some issues I've seen in our CI build...

From https://circleci.com/gh/navit-gps/navit/19559?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link I can see:

CMake Warning at CMakeLists.txt:223 (find_package):
  By not providing "FindQt5Widgets.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "Qt5Widgets", but CMake did not find one.

  Could not find a package configuration file provided by "Qt5Widgets" with
  any of the following names:

    Qt5WidgetsConfig.cmake
    qt5widgets-config.cmake

  Add the installation prefix of "Qt5Widgets" to CMAKE_PREFIX_PATH or set
  "Qt5Widgets_DIR" to a directory containing one of the above files.  If
  "Qt5Widgets" provides a separate development package or SDK, be sure it has
  been installed.

CMake Warning at CMakeLists.txt:224 (find_package):
  By not providing "FindQt5Quick.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "Qt5Quick",
  but CMake did not find one.

  Could not find a package configuration file provided by "Qt5Quick" with any
  of the following names:

    Qt5QuickConfig.cmake
    qt5quick-config.cmake

  Add the installation prefix of "Qt5Quick" to CMAKE_PREFIX_PATH or set
  "Qt5Quick_DIR" to a directory containing one of the above files.  If
  "Qt5Quick" provides a separate development package or SDK, be sure it has
  been installed.

CMake Warning at CMakeLists.txt:225 (find_package):
  By not providing "FindQt5Positioning.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "Qt5Positioning", but CMake did not find one.

  Could not find a package configuration file provided by "Qt5Positioning"
  with any of the following names:

    Qt5PositioningConfig.cmake
    qt5positioning-config.cmake

  Add the installation prefix of "Qt5Positioning" to CMAKE_PREFIX_PATH or set
  "Qt5Positioning_DIR" to a directory containing one of the above files.  If
  "Qt5Positioning" provides a separate development package or SDK, be sure it
  has been installed.

and:

CMake Warning at CMakeLists.txt:594 (message):
  No XSLT processor available.  You have to configure navit.xml yourself, or
  install an XSLT processor (supported:
  saxonb-xslt;saxon;saxon8;saxon-xslt;xsltproc;transform.exe).

Any idea how to solve those? Thanks, Joseph

metalstrolch commented 4 years ago

I am not sure if we should solve them. The Warnings about not found Qt5 packages just indicate that those packages are not there. This causes the Qt5 plug ins not to be built which may be fine. I don't know if CMAKE could be made to not warn here.

Somehow the same is true for the warning about missing XSLT processor. This means that the xslt transformations are not being applied to the resulting navit.xml. Depending on the platform this may be OK. But here I think the better solution would be to add a xslt processor to the corresponding build environments in CI and leave cmake scripts alone.

jkoan commented 4 years ago

I think we cann add the quiet tag to find_package to get rid of that noise. For XSLT i think this one is okay