nbd-wtf / obw

Open Bitcon Wallet (OBW) is a lightweight Android Bitcoin and Lightning wallet
Apache License 2.0
116 stars 18 forks source link

Bug with gossip sync #34

Open Darth-Coin opened 1 year ago

Darth-Coin commented 1 year ago

Description

Weird channels names appeared after udpate OBW to v0.2.0-11.

After update OBW to 0.2.0-11 some weird gossip sync happen:

Eternal said that only changed the alias few days ago and other wallets / channels are connected well. Notice in Amboss its old onion address image

Steps I did:

Will wait few days more to see if the gossip will sync correctly and will report back here.

fiatjaf commented 1 year ago

@Darth-Coin if you can do me a favor, please download the apk from https://github.com/nbd-wtf/obw/actions/runs/3810252555 and live with it for a while so we can see if this problem keeps happening. A proper fix would require doing a big refactor, but this should be enough if the problem is just the ACINQ node replaying very old gossip messages on us.

Darth-Coin commented 1 year ago

@fiatjaf I install it but is coming as separate new app not overwrite the old one. The thing is that with the original OBW I can't make export of the channels to import in any other version. See issue #35 So I can't really test this dev version. Let me know how should I proceed now. If I can make the backup in OBW I could import into this dev version and see how is doing. But I can't trigger the backup (I have 2 HC + 1 normal chan). Yes, I could FC that chan (is with Eternalkr, no problem to communicate) but then we can't test to see this fix in v0.2.0 is ok.

fiatjaf commented 1 year ago

I'll do that other thing.

fiatjaf commented 1 year ago

Actually if you can just use this dev version with a random key and get an HC from Jiraiya and never use it for anything, just wait to see if it changes from Jiraiya to Etleneum eventually.

Darth-Coin commented 1 year ago

Ah OK then, I misunderstood. I can do that sure. testing it for a while.

EDIT testing

Darth-Coin commented 1 year ago
Darth-Coin commented 1 year ago

Actually if you can just use this dev version with a random key and get an HC from Jiraiya and never use it for anything, just wait to see if it changes from Jiraiya to Etleneum eventually.

I check almost twice per day using OBW_DEV version, to see if Jiraiya is changing the name. It is not updating. If you are still looking into fix this issue let me know. I can keep that broken channel open until you find a solution. Maybe this will help others with the same issue. But if you think there's no fix for this, also let me know so I can FC the channel and move on.

fiatjaf commented 1 year ago

Well, if it is not changing back to Etleneum that is a good thing. Does the channel appear as online? I think you can stop checking now. Thank you very much for your help. Is the channel working in the main OBW too or has that one changed to Etleneum?

Darth-Coin commented 1 year ago

yes, the Jiraiya chan is active online and working on both versions (0.2.1 and dev) Only the normal channel with Eternal node is still offline and showing onion address.

Darth-Coin commented 1 year ago

@fiatjaf this morning I tried again to use OBW_DEV version. As usual, I open OBW, wait to sync the channel (I have only one HC with Jiraiya) and sent the payment. I get this error, even that I wait several minutes and no sign on top of sync. image

Then I tried from another device, the normal OBW (latest version) and payment worked.