search

nbd-wtf / obw

Open Bitcon Wallet (OBW) is a lightweight Android Bitcoin and Lightning wallet
Apache License 2.0
116 stars 18 forks source link

PSBT with seedsigner doesnt work #47

Open pony-montana opened 1 year ago

pony-montana commented 1 year ago

The problem accour in the final step of PSBT, when the seedsigner generates the qr containing the signed txo. OBW isnt able to recognize the qr and shows an error. It shows a load screen when scanning qr that end at 99% with the fatal error.

The seesigner signin seems to work (no error reported, no unexpected behaviour and the final qr is correctly generated).

The same issue is present in SBW.

pony-montana commented 1 year ago

Here's the error message (I censored what I naively think are some hashed data like utxos involved in the transaction, pardon me if it result ridiculous).

trap2 trap IMG_20230316_230557

fiatjaf commented 1 year ago

Thank you for this report. I will try to decode the error message and investigate this as soon as possible.

pony-montana commented 1 year ago

I checked how seedsigner manage the PSBT process and I discovered that the final qr generated from seedsigner contains only the sign (not the tx signed). So it is the coordinator (OBW) that need to bring togheter the tx and the sign and then broadcast it.

I dont know how passport works, but in the video seems to work well (https://www.youtube.com/watch?v=93EZrNC7AN0). Highligtning the diffs of the two HW I think we will find what could be the problem. (just speculating: is the passport in the last qr shows the full signed tx and so OBW just scan for a full tx hex?).

Another check that could be useful is analize the wallets that actually works as coordinator with seedsigner; sparrow works well and I think it has some java libraries in common with OBW (hummingbird?).

fiatjaf commented 1 year ago

Thank you very much for digging into this. I am very sad to say that it may be a while until I get a chance to look at this, but eventually I will.

pony-montana commented 1 year ago

dont worry, I see you're busy building amazing stuff :)