Open IJBG opened 4 months ago
The option you suggested sounds good to me
I was going add this today, but..what file do I actually add this to? I get an error adding it to DESCRIPTION and NAMESPACE has the '# Generated by roxygen2: do not edit by hand' warning.
The lines to add are globalVariables(names(mbbs)) globalVariables(names(mbbs_survey_events)) globalVariables(names(mbbs_routes))
That might not cover all of them but it's a good place to start before hunting down smaller functions.
Try adding to mbbs_data.R
@IJBG - I have a few minutes, so I'm going to try to knock this out real quick.
I like the solution of using the .data
pronoun.
tidyverse isn't playing nice with the .data$, still working but giving warnings.
boo.
I'm going to open a new issue to be resolved in new PR.
I'm going to open a new issue to be resolved in new PR.
Nevermind. Let's just keep using this issue.
devtools::check() is passing with no warnings, but some notes. The longest one is about lacking visible binding for global variables. I found some suggestions for fixing it: https://www.r-bloggers.com/2019/08/no-visible-binding-for-global-variable/
@bsaul is this as issue that needs fixing? Would there be anything wrong with using the first option proposed in the above blog post, eg: