nc-minibbs / mbbs

A repository for the Mini-Bird Breeding Survey data
https://minibbs.us
Other
2 stars 0 forks source link

Pivot historical #57

Closed IJBG closed 3 months ago

IJBG commented 3 months ago

I still need to track down some errors (eg, when people put 'X'/'x' instead of a number in the spreadsheets, so I need to consult existing data about if those species were recorded as 0s, 1s, or what) but the overarching code is done and ready for review :) Working through this was helpful for thinking about how to refactor the process_species_comments function. And now I know how to use purrr:map!

The final function in this (where a purrr map is called for everything in stop_level_data_files will become part of the granulate_to_stop function.

Helpful code for testing: scratch_testing_p_Hist_xls.txt

To do week of 5.13

IJBG commented 3 months ago

Done and passing CRAN checks, ready to merge

bsaul commented 3 months ago

@IJBG - Is this waiting for me?

IJBG commented 3 months ago

Yep! If that's okay.

bsaul commented 3 months ago

Yep! If that's okay.

Yep. That's fine; I wasn't sure. FYI - you can request a review from the reviews section at the top of the PR:

image

bsaul commented 3 months ago

@IJBG - I did a quick review with comments on the code. If you want to go ahead and merge to the data in the main branch, go ahead. The comments can mostly be addressed later.

IJBG commented 3 months ago

I'll go ahead and address comments and then merge :)

IJBG commented 3 months ago

Thanks for the review @bsaul !