survey_list accept new entries from prev years

nc-minibbs / mbbs

A repository for the Mini-Bird Breeding Survey data

https://minibbs.us

Other

2 stars 0 forks source link

survey_list accept new entries from prev years #58

Open IJBG opened 3 months ago

IJBG commented 3 months ago

[ ] Find source of survey_list vs latest_surveys (without filtering to just the latest year) discrepancy.
[ ] Likely, the fix will be adding a function to accept new entries to survey_list when they're not already present, regardless of year. This could perhaps be achieved through modification of the existing function without requiring a new one.
[ ] Add date (month and day column) ~~and time~~ to mbbs_survey_events
[ ] Add date ~~and time~~ columns to the 'select' in hist_xls_match_mbbs_format
[ ] Add automated testing to see if things are/are not on survey list

IJBG commented 3 months ago

Date and time do not actually need to be added to mbbs_survey_events because that's information that's in the dataset already itself. The goal of survey_list is to have a stable list of all the surveys, where further information is then added (ie: all the observers processing) in survey_events, and then survey_events gets merged back over date and time are duplicate columns. What's really required here is date and time being added to the hist_xls function, and also getting date and time from the transcribed files.

IJBG commented 3 months ago

But, argument FOR date and time being part of survey_events: it's important information and it's nice to see it in a snapshot where we have all this other information about the surveys. Probably time can be skipped (it's like always 5:30, part of the data collection is that set time). But date is valuable to see alongside the number of species (S) and the number of individual birds (N)

Additionally, for data that is NOT being imported from ebird or the old website, the only record for date may be in survey-list.

IJBG commented 3 months ago

survey_list needs fixing Not sure where this discrepancy is coming from yet (it COULD be pre-dawn owling surveys, it could be times when routes were split and done on different days eg. bc of roadwork or temporary closures) but it's probably that people have uploaded ebird entries that were missing? Requires investigation and update of survey_list. Adding new task above

IJBG commented 3 months ago

Accidentally linked with #69 pull request by referencing it, this issue has not been fixed