nc-minibbs / mbbs

A repository for the Mini-Bird Breeding Survey data
https://minibbs.us
Other
2 stars 0 forks source link

71 add chatham 4 hist xls #74

Closed IJBG closed 2 months ago

IJBG commented 2 months ago

Added some new .xls files that I received by email, discovered a 2005 file within the tabs of the 2011 (yay!), and confirmed that they all run through the hist xls functions fine. Removed the check that the number of species in each file matched what was expected (doesn't matter, and doesn't fit some of the new excel sheets). Here are the tests I'd like to add to the hist_xls r script instead (will change from Draft when done):

IJBG commented 2 months ago

Added checks, but when I added those checks to hist_xls_process_xls got an error. It's related to dplyr's bind-rows (which, I don't use in these scripts), so, going to need to track that done and fix it before this is done. However, tests work wonderfully and I now understand test_that and assertthat.

error: Screenshot 2024-06-06 174708

IJBG commented 2 months ago

Also @IJBG correct some of the spots the auto-formatter was over-zealous, eg: common_name = str_replace( common_name, "^Whip-poor-will$", "Eastern Whip-poor-will" ) (this happened because I tried to format things to fit within 80 characters with a new line) Edit: I was too harsh on this, it looks fine

IJBG commented 2 months ago

Added checks, but when I added those checks to hist_xls_process_xls got an error. It's related to dplyr's bind-rows (which, I don't use in these scripts), so, going to need to track that done and fix it before this is done. However, tests work wonderfully and I now understand test_that and assertthat.

error: Screenshot 2024-06-06 174708

Error not reproducible after opening a new session of R, going to assume it was an error with that R session