nebula-contrib / nebula-node

Nebula Graph Client for Node.js
26 stars 9 forks source link

What about TypeScript support? #4

Closed visortelle closed 2 years ago

visortelle commented 3 years ago

Hi!

Do you have any plans to evolve the node client?

Do you have any plans to rewrite it in TypeScript or at least add .d.ts type definitions?

Examples of the official drivers are written in TypeScript:

wey-gu commented 3 years ago

Thank you @visortelle for bringing this :)! We are sorry that we had been lack of bandwidth evolving the node/JS client Could we introduce TS to the nebula-node @nianiaJR @NicolaCage @hetao92?

xigongdaEricyang commented 2 years ago

We can consider add @types/nebula-node to support ts

wey-gu commented 2 years ago

Thanks @xigongdaEricyang

@nianiaJR @wujjpp , if I understand it correctly, now nebula-node is written in ts already, could we add @types/nebula-node now(or we had already done that)? Plz forgive me if it's a silly question(not familiar with node/typescript)

wujjpp commented 2 years ago

@wey-gu nebula-node was built on top of typescript, and ts declare files are included in build assets.

BTW don’t forget to publish build assets to NPM. Publishing steps are included in README.md

wey-gu commented 2 years ago

thanks @wujjpp ! As ts is supported(as nebula-node is ts-based itself), will close it.

also, i manually published it to @nebula-contrib/nebula-nodejs already, will create corresponding CI later.

ref: https://github.com/nebula-contrib/nebula-node/pull/10