search

nebula-contrib / nebula-node

Nebula Graph Client for Node.js
26 stars 9 forks source link

contribute node.js client #5

Closed Reid00 closed 2 years ago

Reid00 commented 2 years ago

we do some second-dev on this project for Node client, it has been run for months in prod. we plan to donate it with new branch or other someway else you need, what process should us follow? this one https://docs.nebula-graph.com.cn/2.6.1/15.contribution/how-to-contribute/?

wey-gu commented 2 years ago

Amazing, @Reid00 thanks so much,

Could you please help put non-code design in an issue, and push code in PR?

It would be better that could be phased in several PRs while it's already squashed, you could put all changes in one PR.

Thanks!

Reid00 commented 2 years ago

Got it, talked with my colleague, will do it later.

wey-gu commented 2 years ago

I wonder if it's possible to put the follow-up efforts as a nebula hackathon project? @Reid00 @QingZ11

Reid00 commented 2 years ago

talked with my colleague we think it's great.

wey-gu commented 2 years ago

talked with my colleague we think it's great.

Saw your team 🤘🏻, 加油！

wey-gu commented 2 years ago

6 was merged, thanks a ton to @wujjpp @Reid00 for the great work and @nianiaJR for the reviewing! 🎉