support of v3.0

[wey-gu]

as title

[wey-gu]

@wujjpp could you please help briefly guide me/the community on how it should be done to add v3 support? I/or others may spend some time generating needed thrift code and bringing it to nebula-node.

Thanks!

[wujjpp]

@wey-gu I didn't have v3 server for testing.

[wey-gu]

@wey-gu I didn't have v3 server for testing.

If you don't mind, I could share a VM on the cloud with you(with nebula v3 installed), please reach me via mail(weyl.gu at gmail) or WeChat with id: :-D

echo c2l2dmVpCg== | base64 -d

[wujjpp]

@wey-gu required verification via wechat

[wujjpp]

@wey-gu please confirm the following defination:

1. https://github.com/vesoft-inc/nebula/blob/master/src/interface/graph.thrift#L83 The type of latency_in_us, i32 or i64. v2.x is i32, but v3.x changed to i64

2. https://github.com/vesoft-inc/nebula/blob/master/src/interface/common.thrift#L110 v2.x is string, but v3.x is binary

3. https://github.com/vesoft-inc/nebula/blob/master/src/interface/common.thrift#L150 v2.x is list<string>, but v3.x is list<binary>

[wey-gu]

for 1. it's intended as https://github.com/vesoft-inc/nebula/pull/2858 and https://github.com/vesoft-inc/nebula/issues/2650

for 2, and 3. it's binary since 2 years before, also in 2.0~5, in nebula-common it remains binary:

• https://github.com/vesoft-inc/nebula-common/blob/36f5ad9853ae63ddf96bfb21dd968e8ca66a8835/src/common/interface/common.thrift#L102
• https://github.com/vesoft-inc/nebula-common/blob/36f5ad9853ae63ddf96bfb21dd968e8ca66a8835/src/common/interface/common.thrift#L140

Did i miss something here?

[wujjpp]

@wey-gu I'm not sure if all string type are convert to binary

[wey-gu]

@wey-gu I'm not sure if all string type are convert to binary

I will verify this with other clients when I have some time later

[wujjpp]

@wey-gu I have test this PR in nebula v2.6.x and v3.1.0 , it seems working fine

[wey-gu]

@wey-gu I have test this PR in nebula v2.6.x and v3.1.0 , it seems working fine

Wow, got it, 👍🏻

[wujjpp]

DONE