neilenns / vatsim-plan-verifier

Verifies flight plans for vatsim flights
MIT License
2 stars 0 forks source link

Filed cruise altitude of 0 causes odd UI display #505

Closed neilenns closed 1 year ago

neilenns commented 1 year ago

Looks like this:

image

And causes an altitude for direction of flight error. It shouldn't run the test if the filed altitude is 0.

neilenns commented 1 year ago

Finally caught a case where this happens:

plan-verifier:kpdx Importing KPDX flight WJA1738:
  plan-verifier:kpdx {
  plan-verifier:kpdx   "cid": 1746725,
  plan-verifier:kpdx   "name": "Jake KJFK",
  plan-verifier:kpdx   "callsign": "WJA1738",
  plan-verifier:kpdx   "server": "CANADA",
  plan-verifier:kpdx   "pilot_rating": 0,
  plan-verifier:kpdx   "military_rating": 0,
  plan-verifier:kpdx   "latitude": 45.58527,
  plan-verifier:kpdx   "longitude": -122.59089,
  plan-verifier:kpdx   "altitude": 26,
  plan-verifier:kpdx   "groundspeed": 0,
  plan-verifier:kpdx   "transponder": "1155",
  plan-verifier:kpdx   "heading": 44,
  plan-verifier:kpdx   "qnh_i_hg": 30.08,
  plan-verifier:kpdx   "qnh_mb": 1019,
  plan-verifier:kpdx   "flight_plan": {
  plan-verifier:kpdx     "flight_rules": "I",
  plan-verifier:kpdx     "aircraft": "B738/M-LA/L",
  plan-verifier:kpdx     "aircraft_faa": "B738/U",
  plan-verifier:kpdx     "aircraft_short": "B738",
  plan-verifier:kpdx     "departure": "KPDX",
  plan-verifier:kpdx     "arrival": "KHOU",
  plan-verifier:kpdx     "alternate": "",
  plan-verifier:kpdx     "cruise_tas": "280",
  plan-verifier:kpdx     "altitude": "32000",
  plan-verifier:kpdx     "deptime": "1445",
  plan-verifier:kpdx     "enroute_time": "0417",
  plan-verifier:kpdx     "fuel_time": "0512",
  plan-verifier:kpdx     "remarks": "DOF/230827 /V/",
  plan-verifier:kpdx     "route": "IMB BOI TWF TCH JNC SINSY BDROC RSK PUMPS TANER CURLY ABQ CNX HONDS UNNOS FUSCO LLO",
  plan-verifier:kpdx     "revision_id": 1,
  plan-verifier:kpdx     "assigned_transponder": "2262"
  plan-verifier:kpdx   },
  plan-verifier:kpdx   "logon_time": "2023-08-27T14:19:10.7094146Z",
  plan-verifier:kpdx   "last_updated": "2023-08-27T14:29:30.7352085Z"
  plan-verifier:kpdx } +3ms
neilenns commented 1 year ago
plan-verifier:vatsimFlightPlans Storing vatsim flight plan: {
  plan-verifier:vatsimFlightPlans   "cid": 1672853,
  plan-verifier:vatsimFlightPlans   "name": "Nathan Couch KHIO",
  plan-verifier:vatsimFlightPlans   "callsign": "AAL1520",
  plan-verifier:vatsimFlightPlans   "server": "USA-WEST",
  plan-verifier:vatsimFlightPlans   "pilot_rating": 0,
  plan-verifier:vatsimFlightPlans   "military_rating": 0,
  plan-verifier:vatsimFlightPlans   "latitude": 45.59008,
  plan-verifier:vatsimFlightPlans   "longitude": -122.5979,
  plan-verifier:vatsimFlightPlans   "altitude": 39,
  plan-verifier:vatsimFlightPlans   "groundspeed": 0,
  plan-verifier:vatsimFlightPlans   "transponder": "1234",
  plan-verifier:vatsimFlightPlans   "heading": 209,
  plan-verifier:vatsimFlightPlans   "qnh_i_hg": 30.01,
  plan-verifier:vatsimFlightPlans   "qnh_mb": 1016,
  plan-verifier:vatsimFlightPlans   "flight_plan": {
  plan-verifier:vatsimFlightPlans     "flight_rules": "I",
  plan-verifier:vatsimFlightPlans     "aircraft": "B738/M-VGDW/C",
  plan-verifier:vatsimFlightPlans     "aircraft_faa": "B738/L",
  plan-verifier:vatsimFlightPlans     "aircraft_short": "B738",
  plan-verifier:vatsimFlightPlans     "departure": "KPDX",
  plan-verifier:vatsimFlightPlans     "arrival": "KDEN",
  plan-verifier:vatsimFlightPlans     "alternate": "KCOS",
  plan-verifier:vatsimFlightPlans     "cruise_tas": "455",
  plan-verifier:vatsimFlightPlans     "altitude": "35000",
  plan-verifier:vatsimFlightPlans     "deptime": "1630",
  plan-verifier:vatsimFlightPlans     "enroute_time": "0200",
  plan-verifier:vatsimFlightPlans     "fuel_time": "0400",
  plan-verifier:vatsimFlightPlans     "remarks": "PBN/A1B1C1D1S1S2 DOF/221018 REG/N616SB PER/C RMK/TCAS SIMBRIEF /V/",
  plan-verifier:vatsimFlightPlans     "route": "LAVAA6 PDT J16 DOXIE DLN TOFUU FLATI3",
  plan-verifier:vatsimFlightPlans     "revision_id": 1,
  plan-verifier:vatsimFlightPlans     "assigned_transponder": "1616"
  plan-verifier:vatsimFlightPlans   },
  plan-verifier:vatsimFlightPlans   "logon_time": "2023-09-05T23:00:54.2723039Z",
  plan-verifier:vatsimFlightPlans   "last_updated": "2023-09-05T23:02:09.4230646Z"
  plan-verifier:vatsimFlightPlans } +32ms
  plan-verifier:vatsimFlightPlans Processing 693 incoming VATSIM flight plans +5ms
  plan-verifier:vatsimFlightPlans Emitting 1 result for KPDX +378ms
  plan-verifier:flightPlansController Importing flight plan:
  plan-verifier:flightPlansController {
  plan-verifier:flightPlansController   "_id": "64f7b3564df36f3b438beabb",
  plan-verifier:flightPlansController   "cid": 1672853,
  plan-verifier:flightPlansController   "name": "Nathan Couch KHIO",
  plan-verifier:flightPlansController   "callsign": "AAL1520",
  plan-verifier:flightPlansController   "isPrefile": false,
  plan-verifier:flightPlansController   "flightRules": "I",
  plan-verifier:flightPlansController   "groundspeed": 0,
  plan-verifier:flightPlansController   "rawAircraftType": "B738/L",
  plan-verifier:flightPlansController   "departure": "KPDX",
  plan-verifier:flightPlansController   "arrival": "KDEN",
  plan-verifier:flightPlansController   "cruiseAltitude": 0,
  plan-verifier:flightPlansController   "route": "LAVAA6 PDT J16 DOXIE DLN TOFUU FLATI3",
  plan-verifier:flightPlansController   "squawk": "1616",
  plan-verifier:flightPlansController   "remarks": "PBN/A1B1C1D1S1S2 DOF/221018 REG/N616SB PER/C RMK/TCAS SIMBRIEF /V/",
  plan-verifier:flightPlansController   "status": "DEPARTING",
  plan-verifier:flightPlansController   "revision": 2,
  plan-verifier:flightPlansController   "latitude": 45.59008,
  plan-verifier:flightPlansController   "longitude": -122.5979,
  plan-verifier:flightPlansController   "__v": 0
  plan-verifier:flightPlansController } +1s
neilenns commented 1 year ago

And the database shows it stored incorrectly:

image
neilenns commented 1 year ago

Added a ton of logging to the number conversion code.