search

neilhpatel / CodeATale

This is the repository for my Junior Design project. My team developed an interactive web application for children to read the story Dr. Dolittle while improving comprehension skills through quizzes and audio.
0 stars 0 forks source link

Bug Fixes #136

Closed CollinTH closed 2 years ago

CollinTH commented 2 years ago

! I noticed that there are still many instances of session storage being used. Is that intentional?

neilhpatel commented 2 years ago

I think your code isn't the most up to date since there are things being committed that differ from main. For example, there were recent commits to components.js that moved bookmarks to Firebase, but your code is reverting those changes.

jyun261 commented 2 years ago
  • Made so that chapter titles no longer overlapped with the text
  • Fixed the bug caused by spamming the "add page" button. (This involved removing the 150ms delay, which was causing a race condition bug.)
  • Fixed a graphical bug with the audio bar being too large (and aligned the next/previous arrows with the audio bar)
  • Changed the font size on the review screen
  • Changed the font for the question mark on the quiz screen
  • Fixed a bug with definitions being too big and overlapping with the answer buttons on the quiz screen
  • Made so that the number of columns on the chapter select screen was better for mobile
  • Mostly fixed the bug where sometimes the "already queued/added to queue" message would be displayed when it was not supposed to. (However, you can still see the incorrect message for a fraction of a second when it does glitch)

! I noticed that there are still many instances of session storage being used. Is that intentional?

Good job on getting these bug fixes in (couldn't resolve the spam adding messages one myself). And yes, the sessionStorage usage is intentional as all that stores is the current user chapter and page (i'm pretty sure at least) which doesn't need to be stored in the database.