Closed LirryPinter closed 3 years ago
Prototype finished: Review workflow with @joeriverheijden , and later with Jeroen and Chris Gooch
@joeriverheijden
Hi Joeri,
See above in this ticket the estimate.
kr Tom
Thanks Tom :)!
@joeriverheijden @LirryPinter @remcogerlich
Hi Joeri and Lirry,
I showed the design and estimate to Remco. We have following questions / remarks:
The current parramatta board has a special iframe mode, for when the dashboard is shown inside an iframe. Different widgets are not shown in the current iframe mode. Is this iframe mode still applicable to the new design? Is the customer still using the iframe? Which widgets should we not show in iframe mode? What is currently the url where the iframe is shown?
Remco thought because there are so many changes a rewrite is possibly faster then refactoring it. We should seriously consider this.
kr Tom
Yes, The iframe is still applicable. It’s currently only water level measurements (out of my head) that are shown in an iframe on the floodsmart website.
A complete rewrite is defininitly on the table if we think that would increase development speed. But i want a very thorough analysis on if thats really the case before we decide to rewrite.
Kr Joeri
Op di 10 nov. 2020 om 15:53 schreef Tom de Boer notifications@github.com
@joeriverheijden https://github.com/joeriverheijden @LirryPinter https://github.com/LirryPinter @remcogerlich https://github.com/remcogerlich
Hi Joeri and Lirry,
I showed the design and estimate to Remco. We have following questions / remarks:
-
The current parramatta board has a special iframe mode, for when the dashboard is shown inside an iframe. Different widgets are not shown in the current iframe mode. Is this iframe mode still applicable to the new design? Is the customer still using the iframe? Which widgets should we not show in iframe mode? What is currently the url where the iframe is shown?
Remco thought because there are so many changes a rewrite is possibly faster then refactoring it. We should seriously consider this.
kr Tom
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nens/parramatta-dashboard/issues/242#issuecomment-724752371, or unsubscribe https://github.com/notifications/unsubscribe-auth/AELLJSFZ5XCSFR6XZSSZABDSPFHVXANCNFSM4R5OBWQA .
--
Met vriendelijke groet / Kind regards,
Joeri Verheijden
Product Manager Nelen & Schuurmans
+31 (0)30 233 0200 | +31 (0)6 21586741 www.nelen-schuurmans.nl Lizard https://www.lizard.net/ 3Di https://www.3diwatermanagement.com/ Zakkendragershof 34-44, 3511AE, Utrecht [image: Logo N&S] [image: twitter] https://twitter.com/nelenschuurmans [image: linkedin] https://www.linkedin.com/company/245070/
But i want a very thorough analysis on if thats really the case before we decide to rewrite.
What kind of analysis do you have in mind exactly, and how much time is there available to spend on it?
The main problems are that the Parramatta dashboard is the first frontend project and first React project I ever did, so some of its architecture is just wrong, and secondly that I simply have no idea how we could port it to the new design. The code is very tied to the layout of the page.
Jeroen and Chris Gooch asked me to think about the parramatta dashboard and what we can improve.
Design document: https://xd.adobe.com/view/60585b94-db71-4089-bf21-0803942d8c74-350b/