First attempt at JOIN to Rel-Type

[jexp]

• For foreign key column style (no JOIN table)

18

Would love some conceptual feedback, see the TCK file for the current handling

The next one with the JOIN table would need to consider two connected JOINs not 100% sure how to get that other/next join from the current Table<?> or if we would have to do that a level up.

[lukaseder]

Would love some conceptual feedback, see the TCK file for the current handling

Sure, I provided some review, but specific questions are good as well. I'm not sure yet where all your doubts lie, (not knowing too much about Cypher, and especially, common patterns and idioms when writing Cypher)

[jexp]

I'll add a few comments in the code.

[jexp]

@lukaseder unrelated FYI: not sure if the build failure trying to compile jOOQ, was only a temporary glitch in the snapshot? https://github.com/neo4j-contrib/sql2cypher/actions/runs/3991841532/jobs/6847082074

[lukaseder]

@lukaseder unrelated FYI: not sure if the build failure trying to compile jOOQ, was only a temporary glitch in the snapshot? https://github.com/neo4j-contrib/sql2cypher/actions/runs/3991841532/jobs/6847082074

https://github.com/neo4j-contrib/sql2cypher/issues/27

[jexp]

@lukaseder can you have a look at my code-inline questions? I'd be happy to merge this as a WIP state, but want to make sure that I'm not doing stupid things.

[lukaseder]

@lukaseder can you have a look at my code-inline questions?

I already replied to everything, I think? What's missing?

[jexp]

@lukaseder I meant on these:

[lukaseder]

I don't know why my comments are "pending", but I already replied:

[jexp]

@lukaseder GitHub is odd at that, it only sends them immediately if you use "Add single comment" and otherwise it adds/collects them to your "Review" and only publishes them when you finish your "Review" in the top-right box.

[jexp]

Thanks for the answers, I'll go through them.

[lukaseder]

Ugh, I didn't realise I had started a formal "review", sorry

[jexp]

It auto starts a review if you don’t use the single comment button.

[jexp]

Merging this now to make progress, next up is a multi-way join.