neo4j-labs / llm-graph-builder

Neo4j graph construction from unstructured data
Apache License 2.0
344 stars 88 forks source link

Deleting a file fails on local env #465

Closed ionuttiplea closed 6 days ago

ionuttiplea commented 1 week ago

I don't know the specifics, I most likely still lack the understanding of the project but, when I try to delete a file I uploaded, this would be the error in docker image Maybe GCS configuration is mandatory? Is the repository documentation up to date? Or is this an issue that needs to be addressed?

jexp commented 1 week ago

We will fix

punksta commented 1 week ago

Fixed by

adding

from src.shared.common_fn import delete_uploaded_local_file

and using delete_uploaded_local_file(merged_file_path, file_name) instaed of delete_file_from_gcs(BUCKET_UPLOAD,file_name)

kartikpersistent commented 1 week ago

Hi @punksta you can use GCS_FILE_CACHE = False variable in the backend env to process the files locally. If it is true the files will be stored in the google cloud storage.

punksta commented 6 days ago

It looks like Deleting files doesn't check this flag.

praveshkumar1988 commented 6 days ago

@punksta Please check the latest code.

ionuttiplea commented 6 days ago

Hi @punksta you can use GCS_FILE_CACHE = False variable in the backend env to process the files locally. If it is true the files will be stored in the google cloud storage.

I did try that yesterday, it didn't help A temporary solution was commenting this : image The function call delete_file_from_gcs(BUCKET_UPLOAD,file_name) from backend/src/graphDB_dataAccess.py

ionuttiplea commented 6 days ago

@punksta Please check the latest code.

I will, as in the update from yesterday another condition has been added It's cool how fast this was addressed

praveshkumar1988 commented 6 days ago

Please take the latest pull from GIT, It will look like the below screen shot.

image
ionuttiplea commented 6 days ago

It is fixed now, many thanks to everyone involved :100: