search

nerves-networking / vintage_net_wizard

WiFi configuration wizard using vintage_net
Apache License 2.0
60 stars 21 forks source link

Captive portal and RFC 7710 #156

Open fhunleth opened 4 years ago

fhunleth commented 4 years ago

RFC 7710 provides a DHCP option for supporting captive portals. I don't know if OSX, Windows, and Linux support this yet, but it seems like a much nicer way of supporting captive portals for devices that do.

It seems like adding the DHCP option can't hurt anything. DHCP options can be specified using their integer numbers so it's possible to try it out. See https://github.com/nerves-networking/vintage_net/blob/master/lib/vintage_net/ip/dhcpd_config.ex#L17.

fhunleth commented 4 years ago

@jmerriweather - Have you seen RFC 7710 and do you think that it's worth implementing?

jmerriweather commented 4 years ago

I haven't seen RFC 7710, but sounds pretty easy to implement. I can't think of a good reason not to implement it 👍