search

nerves-networking / vintage_net_wizard

WiFi configuration wizard using vintage_net
Apache License 2.0
60 stars 21 forks source link

Mix configuration and args #182

Open mattludwigs opened 4 years ago

mattludwigs commented 4 years ago

Would it be possible to remove mix configurations and just have all args passed in at runtime?

Or at the very least allow all items that are configuration options also be runtime arguments?

fhunleth commented 4 years ago

Just to clarify, are you proposing to switch the application supervisor to a supervisor module that takes its config in start_link? I'd support that.

mattludwigs commented 4 years ago

I think is probably the best solution. Still trying to internalize exposing supervisors and trade-offs of a library using one but can say from experience doing that, I feel like a consuming application has more control and I like it.

What prompted this issue is I noticed when we start the wizard half the config came from app config and half came from what was passed in. Seems a little confusing to me and it would be nice to have the configuration options all passed in the same spot - either runtime or compile time. I personally prefer runtime, which I think does push us down the road of exposing a supervisor.