search

nesquena / backburner

Simple and reliable beanstalkd job queue for ruby
http://nesquena.github.com/backburner
MIT License
428 stars 68 forks source link

Searching/ Canceling jobs based on id #138

Closed lewstherin closed 1 year ago

lewstherin commented 7 years ago

Had a requirement to cancel jobs that have been scheduled. Also, added the functionality to look for jobs based on id, so that we can call lower level beaneater methods on them.

Had to change the requires to require_relatives to support ruby 2.4, otherwise the tests wouldn't pass.

lewstherin commented 7 years ago

Also, ruby 2.4.0 raises deprecation warnings for class Fixnum. Was not sure if I should fix that. Please let me know if I should fix this also.

The failing build reported above is for 1.9.3. I am guessing it has something to do with the require_relatives. Let me know if I should investigate the same.

contentfree commented 7 years ago

@nesquena Should we update the CI config to drop <2.0 support?

@lewstherin Thanks for the PR. I'll take a look later at it (if @nesquena doesn't first)

nesquena commented 7 years ago

@contentfree Yeah good point, we should focus on >= 2.0 now going forward

lewstherin commented 7 years ago

@contentfree @nesquena Any thoughts on merging this?