nesquena / backburner

Simple and reliable beanstalkd job queue for ruby
http://nesquena.github.com/backburner
MIT License
428 stars 68 forks source link

Time to reserve #142

Closed xinuc closed 6 years ago

contentfree commented 6 years ago

I see you closed this PR. There's stuff in here that would be beneficial to Backburner. Maybe split the PR up into several, more-specific PRs.

xinuc commented 6 years ago

Hi @contentfree, sorry, this PR should be for our own fork, not upstream.

Github makes it too easy to create PR for upstream.

contentfree commented 6 years ago

We're certainly open to some upstream PRs. Especially the current thread storage of the connection. We'd like to hear your reasoning on keeping connections open vs keeping them cleaned up.

eltone commented 6 years ago

As a counterargument, I would say that the new connection per enqueue approach does better support the case where a pool of beanstalk servers sit behind a load balancer.

contentfree commented 6 years ago

True true, @eltone