Closed benloh closed 7 months ago
I'll let Kalani weigh in here, but my recollection is that the citation was a more elaborated version of the network name, that if we wanted, instead of:
NetCreate Images of Death network, Node: "Comforting" (ID 3). Last accessed at 12:57 on 11/29/23.
We could have it be:
NetCreate Images of Death network from Kalani's class in 2023, Node: "Comforting" (ID 3). Last accessed at 12:57 on 11/29/23.
I haven't really needed it as much, so will defer to @kalanicraig.
Also, Ben - if we did have it it would be at the level of the whole network / template and calling it citation or citation-text would be great, though where it fits in the data structure likely doesn't matter to us. I think the assumption would be if it is there, use it, if not, use the network name as a default as you did. Does that lead to any thoughts about things being hard or problematic to do?
This appears to work otherwise. If you want to merge and make the citation question a separate issue that'd make sense to me, and I'd likely bump it down in priority since this works for now.
Sorry, also in the prior version the citation > hidden was used to turn off the buttons. That would be nice as a graph-level attribute. That can also be a separate issue for later, though.
In the current templates I am seeing this:
[citation] text = "No citation set" hidden = true
Any nodes / edges with a citation attribute were added by the author of that network for users to type in. So the intent was always that the citation above is what was linked to the citation buttons (referencing the graph name, essentially).
Sorry, this was a case of long long term memory messing with my more recent long term memory. You're absolutely right, we do support the citation field. I think our early versions did use citation fields, but I had forgotten about the fix.
This should be working now. The citation field works in conjunction with the network name. 70638b637658acffc7c7308582140c654eebac8a
This all looks good!
Addresses #86
This re-implements the ability to cite nodes and edges. Clicking the "Cite Node" and "Cite Edge" buttons will show a dialog with the citation text with a "Copy to Clipboard" button. Clicking the button will close the window and copy the text to the clipboard.
This works on most browsers. Tested on:
e.g.![screenshot_1362](https://github.com/netcreateorg/netcreate-itest/assets/1403057/4b0f4ee7-4eef-41b9-9bac-7ec8f3b017f9)
NOTES
Citation
field that would show bibliographic references. Clicking on the "Cite Edge" field would reference that field. With the changeover to built-in fields (source, target) and arbitrary attributes fields (everything else), we no longer have the ability to do that, since acitation
field may or may not exist. So currently we do not reference thecitation
field. One possible workaround is to add support that will automatically add any field namedcitation
(if it exists) to the citation text, and to ignore the text otherwise. Should we add that? Do you want to call itcitation
? Something else? For reference, this is what the citation used to look like: