search

netcreateorg / netcreate-itest

Developing the 2.0 version of NetCreate
https://github.com/netcreateorg/netcreate-2018
Other
0 stars 0 forks source link

Dev jd/fix number #119

Closed jdanish closed 6 months ago

jdanish commented 6 months ago

Made this quick fix to address #118 (the number input field showed a blank rather than a 0, which was confusing when setting it).

jdanish commented 6 months ago

@benloh I went ahead and made the fix so I could avoid disrupting your flow if possible. I don't think it has bigger implications, though of course there might be a better long-term fix. But short-term I think this works? Let me know if there is something different I can test. Or if you prefer to fix this.

benloh commented 6 months ago

@jdanish This works, but you lose the ability to distinguish between no value having been entered vs. deliberately setting it to 0. If that's not important, then this solution is fine.

benloh commented 6 months ago

Also, do you want to update this as v1.5.1 and push to master?

jdanish commented 6 months ago

Ok by me! Yes let’s do that thanks!