search

netcreateorg / netcreate-itest

Developing the 2.0 version of NetCreate
https://github.com/netcreateorg/netcreate-2018
Other
0 stars 0 forks source link

Edge Edit mode allows opening and selecting EdgeTable functions #162

Closed benloh closed 2 months ago

benloh commented 2 months ago

If the EdgeTable is open when you're editing an edge, then you can inadvertently open other nodes and edges, and even try to edit other edges.

This is not a problem with node editing, because node editing acts as a modal.

We can't use the modal approach with edges because we need to be able to select a node when setting edge sources and targets.

Possible solution: In Edge Table disable view and edit buttons and as well as source and target links to open nodes?

The proper solution probably requires some kind of general mode manager?

jdanish commented 2 months ago

Possible solution: In Edge Table disable view and edit buttons and as well as source and target links to open nodes?

that works for me

benloh commented 2 months ago

Fixed by 4df4bdf4cb2618fc2d18c54d9ba24d37b55a099f

benloh commented 2 months ago

Addressed by #175