netcreateorg / netcreate-itest

Developing the 2.0 version of NetCreate
https://github.com/netcreateorg/netcreate-2018
Other
0 stars 0 forks source link

During comment edit prevent opening other comments? #163

Closed benloh closed 2 months ago

benloh commented 2 months ago

Currently while editing a comment, there is nothing preventing you from opening up another comment (either via Node/Edge Table or the unread comment status bar.

Do we need to make the editing comment text a modal to prevent inadvertently browsing away? (Easier to implement, but might be too restrictive) Or do we need to track what has the comment edit status and prevent other events from changing the event mode? (more complex to implement, but may be more intuitive) Or do we just ignore it and let just revert comments that were in process of being edited? (losing a comment is relatively low cost)

Perhaps we need a mode manager? See also #162

benloh commented 2 months ago

It's still possible to end up navigating away during an edit.

We probably need to add a blur detect and:

benloh commented 2 months ago

Addressed by 80831cda73beecb71897e0b80c1c0080c6de5019

benloh commented 2 months ago

Addressed by #175