netcreateorg / netcreate-itest

Developing the 2.0 version of NetCreate
https://github.com/netcreateorg/netcreate-2018
Other
0 stars 0 forks source link

Standalone mode does not display comments #176

Closed benloh closed 1 month ago

benloh commented 2 months ago

In order to track read/unread status, we are currently require login to be able to view any comments.

But since standalone does not require login, comments are not currently displayed.

See https://github.com/netcreateorg/netcreate-2018/wiki/User-Guide

benloh commented 2 months ago

@jdanish Do we need to show comments in standalone mode? Currently comments are ignored because we can't retrieve read/unread status without it. If comments should always be visible, we probably want to introduce a view mode that does not show read/unread status.

jdanish commented 2 months ago

I think it'd be nice to include comments since we might put them in as a guide for viewers. I'm OK with it showing read / unread for the current session (so no change needed?).

benloh commented 2 months ago

OK that makes sense. It does actually require some changes because read/unread status can only be determined after we get the login info

jdanish commented 2 months ago

How big a task is this? I'm tempted to push it off if it feels like more than a few hours to make sure lots of more important things get done.

benloh commented 2 months ago

My guess is it's about two hours. I believe it works with a logged out user, but the standalone stuff is older and we only just re-enabled that earlier today and have not really tested it yet.

jdanish commented 2 months ago

OK, then yeah it'd be cool to do now. Thanks!

benloh commented 2 months ago

Notes to self. Look at:

benloh commented 2 months ago

Fixed with 773862b4fbe6c720eb8d0fd7640b9aff1c2dcc0b