Fix Standalone Mode - Githubissues

netcreateorg / netcreate-itest

Developing the 2.0 version of NetCreate

https://github.com/netcreateorg/netcreate-2018

Other

0 stars 0 forks source link

Fix Standalone Mode #177

Closed dsriseah closed 2 months ago

dsriseah commented 2 months ago

Addressing Issue #68

Resolution - app/assets/index.html is copied as-is to the public directory, but had not been updated to include the new ursys-core and ursys-addon libraries, which was the cause of the error.

TEST

Follow the packaging instructions

npm run dev once
npm run package afterwards
copy the contents of the public folder to your webserver docroot
see if it works!

jdanish commented 2 months ago

This looks good to me! It'd be nice to either hide comments or just display them on the assumption that we might want to share comments in our standalone either to show what things are or preserve student comments. But I think let's merge that and add that as a feature down the road?

benloh commented 2 months ago

Confirmed works.

benloh commented 2 months ago

This looks good to me! It'd be nice to either hide comments or just display them on the assumption that we might want to share comments in our standalone either to show what things are or preserve student comments. But I think let's merge that and add that as a feature down the road?

See #176