search

netcreateorg / netcreate-itest

Developing the 2.0 version of NetCreate
https://github.com/netcreateorg/netcreate-2018
Other
0 stars 0 forks source link

View and edit buttons disappearing in current dev branch in tables (node and edge) #225

Closed jdanish closed 1 month ago

jdanish commented 1 month ago

Just noticed. Click on node / edge table, view and edit buttons flash visible then disappear.

jdanish commented 1 month ago

This appears to have been created by some weird state we got into in the sense that it now works fine again. I'll see if I can reproduce, but if you have ideas let me know.

benloh commented 1 month ago

It's most likely related to someone locking and unlocking a comment, node, or edge. This possibly includes network activity (e.g. someone else is editing).

There are a number of optimizations that we need to revisit. We had to do a fair amount of locking/unlocking to make sure users can't inadvertently make certain changes while anything is being edited. It probably would've been easier to establish some kind of edit modal approach, but you lose the ability to do stuff like select nodes as edge targets.

On a slower Chromebook, for instance, you can see a flash of "This node is currently being edited by someone else, please try again later" as you save comments/nodes/edges.

jdanish commented 1 month ago

Looks like it might be due to template editing. Marking this closed since that's fine / correct.