search

netcreateorg / netcreate-itest

Developing the 2.0 version of NetCreate
https://github.com/netcreateorg/netcreate-2018
Other
1 stars 1 forks source link

Feature change: children accidentally hit return in search box, creating new nodes #285

Open jdanish opened 1 month ago

jdanish commented 1 month ago

We noticed a LOT of duplicate nodes in the recent implementation round. Running hypothesis is that kids search and hit enter without realizing. Some solutions:

  1. Simply disable the create on enter
  2. Make this something that is defined in the template so that advanced teams can still use enter, but we can turn off for kids
  3. Something more complicated was suggested like control-enter

It'd be nice to do 1 short-term, and 2 long-term. 3 seems not worth the effort.

Flagging @kalanicraig to weigh in.

kalanicraig commented 1 month ago

3 would also be a non-standard way to use the enter key, so I think disable create-on-enter so the warning is more visible.

I’d need to see how 2 works to get a better sense of it.

On Thu, Oct 3, 2024 at 11:34 AM Joshua Danish @.***> wrote:

We noticed a LOT of duplicate nodes in the recent implementation round. Running hypothesis is that kids search and hit enter without realizing. Some solutions:

  1. Simply disable the create on enter
  2. Make this something that is defined in the template so that advanced teams can still use enter, but we can turn off for kids
  3. Something more complicated was suggested like control-enter

It'd be nice to do 1 short-term, and 2 long-term. 3 seems not worth the effort.

Flagging @kalanicraig https://github.com/kalanicraig to weigh in.

— Reply to this email directly, view it on GitHub https://github.com/netcreateorg/netcreate-itest/issues/285, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACKL4NE2AYI6KV7PEW2RNLDZZVPYDAVCNFSM6AAAAABPKBVQ2CVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU3DIMZWGU4DMNI . You are receiving this because you were mentioned.Message ID: @.***>

benloh commented 1 month ago

We do detect when a duplicate node is added, but perhaps the message is too subtle?

So another approach would be to block the node from being added with some kind of dialog. And then preferences would either allow you to create it with confirmation (e.g. "Yes, add duplicate node"), or you'd get the warning but be forced to change the node name (e.g. "Please use a name that doesn't already exist").

Unless the problem really is that people are hitting "Enter" too quickly...

jdanish commented 1 month ago

Actually:

  1. Type a node name, e.g., "Node 1"
  2. Press Enter
  3. Press it again because you are impatient
  4. One more!
  5. Now press cancel because you realize there are duplicates

Each Enter added a new one and the cancel only gets rid of one of them

Proposed solution: 1) don't respond to enter if a node creation dialogue is open, 2) make the duplicate warning text easier to see (e.g., red).