netcreateorg / netcreate-itest

Developing the 2.0 version of NetCreate
https://github.com/netcreateorg/netcreate-2018
Other
0 stars 0 forks source link

Build Configuration Fixes #93

Closed dsriseah closed 8 months ago

dsriseah commented 8 months ago

Ben reported a mystery error of node_modules being missing from the repo, and as these directories shouldn't be in the directory in the first place an investigation was spawned! The following changes were made:

  1. removed files that had been committed by accident in _ur/node_modules
  2. clearer the hidden files settings in the code-workspace, as node_modules was one of them which hid the accidental commit for a long time!
  3. fixed bad .gitignore pattern **/node_modules/* to **/node_modules
  4. extra: fixed broken npm run build-libs scripts
  5. extra: added *_nocommit to gitignore so temporary directories could be kept in the repo folder

TO TEST

next, in the main netcreate-itest directory:

next, check that the node_modules directories in the following directories are grayed-out and are not showing up as "modified files" in your git client.

benloh commented 8 months ago

Confirmed works.

benloh commented 8 months ago

One clarification

next, check that the node_modules directories in the following directories are grayed-out and are not showing up as "modified files" in your git client.

The folder that is grayed out is node_modules not _node_modules

dsriseah commented 8 months ago

good catch! fixing for posterity :-)

The folder that is grayed out is node_modules not _node_modules